Skip to content

Conversation

@SouthEndMusic
Copy link
Collaborator

Fixes #1919

@SouthEndMusic SouthEndMusic requested a review from visr July 14, 2025 08:24
@visr
Copy link
Member

visr commented Jul 14, 2025

Nice! Let's switch to PCHIPInterpolation for this and #2446. I think you also need to add Plots to the root environment, though I hope that won't undo the gains from #2441 too much.

@SouthEndMusic
Copy link
Collaborator Author

Turns out PCHIPInterpolation cannot deal with only 2 data points:

SciML/DataInterpolations.jl#446

Will do a quick fix on our side with a reference to the issue

@SouthEndMusic
Copy link
Collaborator Author

SouthEndMusic commented Jul 16, 2025

Of course some simulation results changed due to this interpolation type change, I guess the benchmark simulation results for the integration and regression tests have to be updated as well

@visr visr merged commit 07e985d into main Jul 17, 2025
16 of 17 checks passed
@visr visr deleted the smoother_rating_curve branch July 17, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smoothing the Q(h) relation

3 participants